-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing of setup and teardown actions in JUnit 4 #8030
Merged
daniel-mohedano
merged 12 commits into
master
from
daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4
Dec 2, 2024
Merged
Tracing of setup and teardown actions in JUnit 4 #8030
daniel-mohedano
merged 12 commits into
master
from
daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupLoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
dateFormat X
axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1376
. : milestone, 1357,
appsec (1.778 ms) : 1755, 1801
. : milestone, 1778,
appsec_no_iast (1.767 ms) : 1742, 1792
. : milestone, 1767,
iast (1.504 ms) : 1481, 1527
. : milestone, 1504,
profiling (1.561 ms) : 1537, 1585
. : milestone, 1561,
tracing (1.512 ms) : 1487, 1536
. : milestone, 1512,
section candidate
no_agent (1.353 ms) : 1334, 1372
. : milestone, 1353,
appsec (1.764 ms) : 1740, 1789
. : milestone, 1764,
appsec_no_iast (1.77 ms) : 1745, 1794
. : milestone, 1770,
iast (1.491 ms) : 1468, 1514
. : milestone, 1491,
profiling (1.514 ms) : 1490, 1538
. : milestone, 1514,
tracing (1.519 ms) : 1494, 1544
. : milestone, 1519,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
dateFormat X
axisFormat %s
section baseline
no_agent (378.368 µs) : 359, 398
. : milestone, 378,
iast (492.647 µs) : 471, 514
. : milestone, 493,
iast_FULL (655.985 µs) : 634, 678
. : milestone, 656,
iast_GLOBAL (519.947 µs) : 499, 541
. : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (495.839 µs) : 475, 517
. : milestone, 496,
iast_INACTIVE (451.754 µs) : 431, 472
. : milestone, 452,
iast_TELEMETRY_OFF (489.516 µs) : 468, 511
. : milestone, 490,
tracing (448.227 µs) : 428, 469
. : milestone, 448,
section candidate
no_agent (380.47 µs) : 361, 400
. : milestone, 380,
iast (494.585 µs) : 473, 516
. : milestone, 495,
iast_FULL (660.218 µs) : 639, 682
. : milestone, 660,
iast_GLOBAL (520.383 µs) : 499, 542
. : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (497.827 µs) : 476, 519
. : milestone, 498,
iast_INACTIVE (453.714 µs) : 433, 474
. : milestone, 454,
iast_TELEMETRY_OFF (479.762 µs) : 459, 501
. : milestone, 480,
tracing (454.786 µs) : 434, 476
. : milestone, 455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
dateFormat X
axisFormat %s
section baseline
no_agent (15.398 s) : 15398000, 15398000
. : milestone, 15398000,
appsec (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
iast (18.99 s) : 18990000, 18990000
. : milestone, 18990000,
iast_GLOBAL (18.209 s) : 18209000, 18209000
. : milestone, 18209000,
profiling (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
tracing (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
section candidate
no_agent (15.41 s) : 15410000, 15410000
. : milestone, 15410000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
iast_GLOBAL (17.692 s) : 17692000, 17692000
. : milestone, 17692000,
profiling (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~948fe8ac30, baseline=1.44.0-SNAPSHOT~9f01834ab7
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.339 ms) : 2297, 2380
. : milestone, 2339,
iast (2.078 ms) : 2025, 2130
. : milestone, 2078,
iast_GLOBAL (2.118 ms) : 2065, 2171
. : milestone, 2118,
profiling (1.951 ms) : 1909, 1993
. : milestone, 1951,
tracing (1.919 ms) : 1879, 1959
. : milestone, 1919,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.333 ms) : 2291, 2375
. : milestone, 2333,
iast (2.076 ms) : 2023, 2128
. : milestone, 2076,
iast_GLOBAL (2.118 ms) : 2065, 2170
. : milestone, 2118,
profiling (1.954 ms) : 1911, 1998
. : milestone, 1954,
tracing (1.917 ms) : 1878, 1957
. : milestone, 1917,
|
nikita-tkachenko-datadog
approved these changes
Dec 2, 2024
daniel-mohedano
deleted the
daniel.mohedano/SDTEST-1224-setup-teardown-tracing-junit4
branch
December 2, 2024 11:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
@Before
,@After
,@BeforeClass
,@AfterClass
,@BeforeParam
,@AfterParam
).Motivation
To provide more complete information regarding test runs, the setup and teardown actions can be traced. This is already implemented for JUnit 5, which implies that it would also be nice to have for JUnit 4.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-1224